• julianwgs@discuss.tchncs.de
    link
    fedilink
    arrow-up
    12
    arrow-down
    1
    ·
    2 days ago

    Why not?

    We did that for a Plotly dashboard in Python. We copied the database into a read-only in-memory sqlite database (it is quite small, only a couple thousand entries) to prevent any damages outside the dashboard. The data only gets updated every couple of days. You could skip this step. Then with sqlite you can restrict what action a query can use (SELECT, JSON, etc.) and you can restrict the instructions per query to prevent denial of service. It works like a charm and is much simpler than providing a REST API. Also the user might already know SQL.

    I am actually planning something similar for a task management web app I am building at the moment (additionally to providing a REST API). No need to learn another query language like in Jira.

    • shoo@lemmy.world
      link
      fedilink
      arrow-up
      19
      ·
      2 days ago

      Couple of reasons of varying importance:

      • Security. Even when you limit operations or table access it’s very easy to mess something up. Some new employee starts storing sensitive data in the wrong place or a db admin accidentally turns off the wrong permissions, etc…
      • It’s secretly more overengineered than a standard api despite looking simpler. If your app needs extremely robust query capabilities then you probably have a use case for an entire analytics stack and could use an open source option. Otherwise your users probably just need basic search, filtering, sorting, etc…
      • Ungodly, Flex Tape tier tight coupling. Part of the purpose of an api is to abstract away implementation details and present a stable contract. Now if you want to migrate/upgrade the database or add a new data source, everyone has to know about it and it’s potentially a major breaking change.
      • Familiarity. If someone else steps in to maintain it it’s much easier to get up to speed with a more standard stack. You don’t need a seven layer salad of enterprise abstraction bullshit, but it’s useful to see a familiar separation of auth, queries, security, etc…
      • Having the option to do business logic outside of the database can save countless headaches. Instead of inventing views or kludging sprocs to do some standard transformation, you can pull in a mature library. Some things, such as scrubbing PII, are probably damn near impossible without a higher tier layer to work in.
      • Client support. Your browser/device probably has a few billion options for consuming a REST/HATEOAS/graphql/whatever api. I doubt there’s many direct sql options with wide support.

      I probably wouldn’t do it outside of a tiny solo project. There are plenty of frameworks which do similar things (such as db driven apis) without compromising on flexibility, security or features.

      • Garbagio@lemmy.zip
        link
        fedilink
        arrow-up
        1
        ·
        1 day ago

        Security

        This is why I just add a username and password field to all my database tables, then append on the back end “and username is not null and password is not null”

  • Buckshot@programming.dev
    link
    fedilink
    arrow-up
    14
    ·
    2 days ago

    I got dumped with fixing some bugs in a project written by a contractor who had literally done this but with extra steps.

    Backend was sql server and c#/asp.

    There was an api endpoint that took json, used xslt to transform to xml. Then called the stored procedure specified in request passing the xml as a parameter.

    The stored procedure then queried the xml for parameters, executed the query, and returned results as xml.

    Another xslt transformed that to json and returned to the client.

    It was impressive how little c# there was.

    Despite holding all the business logic, the sql was not in source control.

    • lordbritishbusiness@lemmy.world
      link
      fedilink
      English
      arrow-up
      1
      ·
      20 hours ago

      Worst thing with databases. Used to quote to my interns, “No spooky action at a distance” logic has to be in front of you and in git. Anything else is a recipe for bugs and undetectable errors.

  • Blackmist@feddit.uk
    link
    fedilink
    English
    arrow-up
    6
    ·
    2 days ago

    I did this just to reduce network latency. It’s not for public use, and tbh, I don’t think you can even get at it from outside the VPN.

      • Blackmist@feddit.uk
        link
        fedilink
        English
        arrow-up
        1
        ·
        12 hours ago

        I haven’t been down to test their public wifi in the cafe to see if that can access it.

        The guy who installed it used to work for us and is a known clown, so it’s entirely possible.

        Although if it is, there’s way worse things they can do from there. Like connect to the actual database for a start.

        • luciferofastora@feddit.org
          link
          fedilink
          arrow-up
          1
          ·
          34 minutes ago

          Does the database use the same authentication and permissions as the API? If the API authenticates against the DB with a technical user, it may be still be an exploitable vulnerability for people who can’t access the DB directly but can access the API. I don’t know what database it is, what other databases run on the same server and what privileges might be achievable or escalatable, but generally “there are worse weaknesses” isn’t a solid security policy.

          You could give me a VPN access and I’ll take a look around :p

          (Please don’t, actually – in case it needs to be said, running pentests on prod is a dangerously bad idea already even before we get to the whole “trusting a stranger on the Internet just because they sound sorta knowledgeable” issue)

    • passepartout@feddit.org
      link
      fedilink
      arrow-up
      122
      ·
      3 days ago

      My friend who helped me research the OAuth vulnerabilities was let go for “security concerns from corporate”

      Good old shooting the messenger.

      • ZoteTheMighty@lemmy.zip
        link
        fedilink
        arrow-up
        15
        arrow-down
        2
        ·
        3 days ago

        I mean, they were an employee who was exploring security vulnerabilities with a non-employee who has a blog. I would have fired them too.

        • passepartout@feddit.org
          link
          fedilink
          arrow-up
          14
          ·
          3 days ago

          It is indeed a very risky move without a lot to gain for him personally. But I could guess McDonald’s would have forced him to ignore it and shut up about it if he disclosed this to the higher ups himself, in which case I would have gladly left myself instead.

    • lordbritishbusiness@lemmy.world
      link
      fedilink
      English
      arrow-up
      2
      ·
      20 hours ago

      Yeah, if I heard a junior dev say that in earshot I’ll be pulling them into a room for the list-of-reasons-that’s-dumb. Even the AI code assistants would directly say it’s not advisable.

  • x00z@lemmy.world
    link
    fedilink
    English
    arrow-up
    29
    ·
    3 days ago

    This is still over engineered. Just connect directly to the database from the client instead of having an API endpoint.

  • Iced Raktajino@startrek.website
    link
    fedilink
    arrow-up
    35
    ·
    3 days ago

    I work with several people who would think this is a good idea.

    When they push it to prod, and our WAF goes 403 on every request, then suddenly it’s my problem to “fix”. Eye Roll

  • troed@fedia.io
    link
    fedilink
    arrow-up
    16
    ·
    3 days ago

    Great idea. How can we submit this to all AI scrapers?

    /cybersec red teamer

  • kibiz0r@midwest.social
    link
    fedilink
    English
    arrow-up
    10
    ·
    3 days ago

    Does ReST mean anything anymore? It was originally a set of principles guiding the development of the HTTP 1.1 spec. Then it meant mapping CRUD to HTTP verbs so application-agnostic load balancers could work right. And now I guess it’s just HTTP+JSON?